Update the compiler diagnostic in PullDiagnosticsTests.testNoteInSecondaryFile() - #2750
Open
tshortli wants to merge 1 commit into
Open
Update the compiler diagnostic in PullDiagnosticsTests.testNoteInSecondaryFile()#2750tshortli wants to merge 1 commit into
PullDiagnosticsTests.testNoteInSecondaryFile()#2750tshortli wants to merge 1 commit into
Conversation
…ndaryFile(). The location and highlights for Swift compiler diagnostics about unavailable declarations are changing in swiftlang/swift#91369. The PullDiagnosticsTests.testNoteInSecondaryFile() test would start failing as a result, so update the test to verify the same fundamental behavior as it did before but using a different compiler diagnostic that isn't changing.
tshortli
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
August 11, 2026 22:12
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The location and highlights for Swift compiler diagnostics about unavailable declarations are changing in swiftlang/swift#91369. The
PullDiagnosticsTests.testNoteInSecondaryFile()test would start failing as a result, so update the test to verify the same fundamental behavior as it did before but using a different compiler diagnostic that isn't changing.