Update the 'Main Actor' section to clarify isolation for non-isolated functions#427
Open
ArtemAK wants to merge 1 commit into
Open
Update the 'Main Actor' section to clarify isolation for non-isolated functions#427ArtemAK wants to merge 1 commit into
ArtemAK wants to merge 1 commit into
Conversation
Clarify that functions do not inherit isolation from callers. The current phrasing implies inheritance, which contradicts actor isolation principles. The update specifies that execution context is determined by the callee's isolation domain and boundary rather than being a side effect of the caller's state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the 'Main Actor' section to correct a phrasing that implies functions inherit actor isolation from their callers.
In the current text, the use of 'because' suggests downloadPhoto runs off the main actor only because its caller is also off the main actor. This contradicts the principle of actor isolation and static isolation, where a function's isolation is determined by its own declaration.
I have updated the text to clarify that the execution context is determined by the callee's isolation domain and its isolation boundary, rather than being a side effect of the caller's state.