Skip to content

Remove dead code in 64-bit overflow protection #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead code in 64-bit overflow protection #5371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Sources/CoreFoundation/CFRuntime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,11 +1460,6 @@ static CFTypeRef _CFRetain(CFTypeRef cf, Boolean tryR) {
return cf;
}

if (__builtin_expect(__CFHighRCFromInfo(info) == ~0U, false)) {
// Overflow will occur upon add. Turn into constant CFTypeRef (rc == 0). Retain will do nothing, but neither will release.
__CFBitfield64SetValue(newInfo, HIGH_RC_END, HIGH_RC_START, 0);
}

// Increment the retain count and swap into place
newInfo = info + RC_INCREMENT;
} while (!atomic_compare_exchange_strong(&(((CFRuntimeBase *)cf)->_cfinfoa), &info, newInfo));
Expand Down