Foundation: remove overlay for testing unresovled failure - #5504
Open
compnerd wants to merge 1 commit into
Open
Conversation
Member
Author
|
@swift-ci please test |
jmschonfeld
reviewed
Jul 14, 2026
| DWORD(WinSDK.MOVEFILE_WRITE_THROUGH) | ||
| } | ||
|
|
||
| internal var OPEN_EXISTING: DWORD { |
Contributor
There was a problem hiding this comment.
Looks like this one was at least required:
C:\Users\swift-ci\jenkins\workspace\swift-corelibs-foundation-PR-windows\swift-corelibs-foundation\Sources\Foundation\FileManager+Win32.swift:187:28: error: cannot convert value of type 'Int32' to expected argument type 'DWORD' (aka 'UInt32')
185 | CreateFileW($0, 0,
186 | FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
187 | nil, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, nil)
| `- error: cannot convert value of type 'Int32' to expected argument type 'DWORD' (aka 'UInt32')
188 | }
189 | if hFile == INVALID_HANDLE_VALUE {
Member
Author
There was a problem hiding this comment.
Yeah, I think that I need to just do the typecasts here in the repo. There is a compiler issue that the removal fixes :(.
Contributor
There was a problem hiding this comment.
For context, do you have a link to the compiler issue that this removal is fixing? And is there a future in which this declaration is imported as a DWORD automatically or is it intentionally imported as a different type than how its used here?
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows platform |
This allows working around an diagnosed failure in the compiler with canonically typed imports.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.