Skip to content

Removing additional quotes around values in a XCTAssertEqual - #482

Draft
abrarShariar wants to merge 1 commit into
swiftlang:mainfrom
abrarShariar:abrar-shariar/473/remove-quotes
Draft

Removing additional quotes around values in a XCTAssertEqual#482
abrarShariar wants to merge 1 commit into
swiftlang:mainfrom
abrarShariar:abrar-shariar/473/remove-quotes

Conversation

@abrarShariar

@abrarShariar abrarShariar commented Mar 24, 2024

Copy link
Copy Markdown
Contributor

Removing unnecessary quotes but keeping the parenthesis as mentioned here:

#473

The parenthesis would still show that whatever it wraps is a value type and separate it out of the actual logging text.

for example:

("3") is not equal to ("1")

becomes:

(3) is not equal to (1)

for strings:

(Hello world) is not equal to (Hello)

@abrarShariar
abrarShariar marked this pull request as draft March 24, 2024 22:36
@abrarShariar

Copy link
Copy Markdown
Contributor Author

Taking it to draft to gather feedback from team and add additional enhancement. #473 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant