Add XCTestCase.current property. - #535
Open
grynspan wants to merge 1 commit into
Open
Conversation
This PR adds a class property to `XCTestCase` to let you get the currently-running instance. We already have equivalent API in Swift Testing. Resolves #491. Resolves rdar://130966686.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
March 9, 2026 19:13
Contributor
Author
|
@swift-ci test |
jerryjrchen
approved these changes
Mar 26, 2026
jerryjrchen
left a comment
jerryjrchen
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming the potential defer out of order issue isn't a big deal. Note this will probably conflict with #538
| Self._current.withLock { $0 = nil } | ||
| } | ||
| testRun.start() | ||
| defer { |
Contributor
There was a problem hiding this comment.
These defer blocks could execute out of order right? So it's possible for testRun.stop() to happen after current test case is set to nil. Can that lead to any correctness issues?
Contributor
Author
There was a problem hiding this comment.
Within a given function, defer blocks always execute in the reverse of the order they are declared in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a class property to
XCTestCaseto let you get the currently-running instance. We already have equivalent API in Swift Testing.Resolves #491.
Resolves rdar://130966686.