Skip to content

encode relationshipsByLanguage and orphanRelationships in dump-unified-graph#49

Open
QuietMisdreavus wants to merge 2 commits into
swiftlang:mainfrom
QuietMisdreavus:fix-encodable
Open

encode relationshipsByLanguage and orphanRelationships in dump-unified-graph#49
QuietMisdreavus wants to merge 2 commits into
swiftlang:mainfrom
QuietMisdreavus:fix-encodable

Conversation

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

Bug/issue #, if applicable: None

Summary

When #28 landed, the code for dump-unified-graph was not updated to use the new relationship data. This PR updates the Encodable extension on UnifiedSymbolGraph to use the relationshipsByLanguage and orphanRelationships properties instead of the old unified relationships property. This removes a deprecation warning when building SymbolKit.

Dependencies

None

Testing

Rerun the testing instructions for #29. The Xcode 14 beta will generate multiple symbol graphs per-language, so passing the symbol-graph directory from a project's build folder to --symbol-graph-dir will work.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ n/a ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ n/a ] Updated documentation if necessary

@QuietMisdreavus

Copy link
Copy Markdown
Contributor Author

@swift-ci Please test

@kirillyakimovich

Copy link
Copy Markdown

Hey! Is there a plan to merge this?

@stefanpenner

Copy link
Copy Markdown

Bumping this — the deprecation warning on relationships in UnifiedSymbolGraph+Encodable.swift still fires on every build that uses rules_swift (e.g. via Bazel). Would be great to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants