[DO NOT MERGE] Support for unknown platforms names#87
Open
sofiaromorales wants to merge 2 commits into
Open
Conversation
This change removes the addition of the string `Unsupported OS:` to platform names that are not considered as known platforms. Known platforms are apple platforms + Linux.
DocC is being used to document REST APIs and other codebases outside of the initial ecosystem use case. Having this string was makig Symbolkit incompatible for all this other documentation use cases.
rdar://112033286
sofiaromorales
changed the title
Contributor
|
@swift-ci Please test |
Contributor
|
If this shouldn't be merged yet, the PR should be marked as a draft. |
QuietMisdreavus
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 112033286
Summary
Removed Unsupported OS string from unknown platforms
This change removes the addition of the string
Unsupported OS:to platform names that are not considered as known platforms. Known platforms are apple platforms + Linux.DocC can be used to document other codebases with different platforms outside of the initial ecosystem use case. Having this string was making Symbolkit platform name logic incompatible for all this other documentation use cases.
rdar://112033286
Dependencies
N/A
Testing
Review unit tests.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded