Check that swift-frontend supports ipi clang module before transferri…#2155
Merged
Conversation
sepy97
requested review from
DougGregor,
artemcm,
cachemeifyoucan,
compnerd and
owenv
as code owners
Contributor
Author
|
@swift-ci please test |
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
Contributor
There was a problem hiding this comment.
Change LGTM. Comment in test.
| // Single flag is forwarded. | ||
| do { | ||
| var driver = try TestDriver(args: ["swiftc", "-ipi-clang-module", "Foo", "foo.swift"]) | ||
| guard driver.isFrontendArgSupported(.ipiClangModule) else { return } |
Contributor
There was a problem hiding this comment.
It is preferred to use test trait requireFrontendArgSupport than return in the middle of the tests.
…ng the flag to the frontend. This way no "unknown argument" error would occur if swift-frontend does not support clang ipi modules rdar://181745695
sepy97
force-pushed
the
ipi-frontend-verify
branch
from
347fb37 to
0215a47
Compare
Contributor
Author
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Jul 8, 2026
nkcsgexi
approved these changes
Jul 9, 2026
Contributor
Author
|
@swift-ci please test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng the flag to the frontend.
This way no "unknown argument" error would occur if swift-frontend does not support clang ipi modules
rdar://181745695