Open
Conversation
Contributor
|
@colemancda In my opinion, blink example should be left to just blink, as intended by its nature. You could consider creating a separate Bluetooth example. |
2852115 to
087971c
Compare
087971c to
d226fce
Compare
Author
|
@erhankur I moved the example to its own and removed the blink code. |
Contributor
|
@colemancda Thank you for the nice work! I didn't play with bluetooth examples before. Just wanted to build to see if there is an issue. Warnings regarding macro redefinitions ; Probably you will need to cleanup BringingHeader.h .Removing #include "esp_nimble_cfg.h" fixes the warnings. And error; |
Author
|
@erhankur That's odd, I did not get that error with toolchain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new ESP32 example that advertises as an iBeacon in addition to its name and address.
Also adds some Swift wrappers for the ESP32 SDK and NimBLE.