Skip to content

Update CMakeLists.txt - #1240

Merged
rintaro merged 1 commit into
swiftlang:mainfrom
tshortli:cmake-fix
Jul 2, 2026
Merged

Update CMakeLists.txt#1240
rintaro merged 1 commit into
swiftlang:mainfrom
tshortli:cmake-fix

Conversation

@tshortli

@tshortli tshortli commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

In #1236 files were renamed and added but CMakeLists.txt was not updated, breaking swiftlang CI builds on Windows.

@tshortli
Update CMakeLists.txt.
fee3b54 
In swiftlang#1236 files were renamed and
added but CMakeLists.txt was not updated, breaking swiftlang CI builds on
Windows.
This was referenced Jul 2, 2026
Merged
Merged
@rintaro rintaro mentioned this pull request Jul 2, 2026
Closed
@rintaro
rintaro enabled auto-merge July 2, 2026 04:20
@rintaro
rintaro merged commit 6ac428e into swiftlang:main Jul 2, 2026
30 checks passed
@tshortli
tshortli deleted the cmake-fix branch July 2, 2026 04:45
@finagolfin finagolfin mentioned this pull request Jul 2, 2026
Merged
@allevato

allevato commented Jul 2, 2026

Copy link
Copy Markdown
Member

Sorry about that, thanks for the fix.

I thought our PR testing exercised the CMake build at least on Windows. I guess that's not the case? We should fix this because adding or renaming a source file shouldn't require doing the full swift-ci test flow just to cover one platform.

@rintaro

rintaro commented Jul 2, 2026

Copy link
Copy Markdown
Member

swift-tools-protocols is testing CMake builds in PR GitHub actions
https://github.com/swiftlang/swift-tools-protocols/blob/0a4bf639ede626ee9776714b26738bd47a2345db/.github/workflows/pull_request.yml#L29-L43
But it's implemented as a SwiftPM plugin.
https://github.com/swiftlang/swift-tools-protocols/blob/0a4bf639ede626ee9776714b26738bd47a2345db/Package.swift#L174-L183
I don't really know why it's like so.

@rintaro

rintaro commented Jul 2, 2026

Copy link
Copy Markdown
Member

Changing it to shell scripts so swift-format can easily adopt it
swiftlang/swift-tools-protocols#71

@Catfish-Man Catfish-Man mentioned this pull request Jul 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rintaro rintaro rintaro approved these changes
@allevato allevato Awaiting requested review from allevato allevato is a code owner
@dylansturg dylansturg Awaiting requested review from dylansturg dylansturg is a code owner
@hborla hborla Awaiting requested review from hborla hborla is a code owner
@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tshortli @allevato @rintaro