Skip to content

[Proposal] Category support for Locale.Region #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2025

Conversation

itingliu
Copy link
Contributor

@itingliu itingliu commented Apr 12, 2025

Propose extending Locale.Region to support grouping the return result by types, such as whether it's a territory or continent.

Implementation: #1253

@itingliu itingliu added the proposal This PR is for a proposal label Apr 17, 2025
@itingliu itingliu marked this pull request as ready for review April 17, 2025 00:43
@itingliu
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@jmschonfeld jmschonfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rename the file to 0028-...

@@ -0,0 +1,198 @@
# `Locale.Region.Category`

* Proposal: [SF-NNNN](NNNN-locale-region-category.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Proposal: [SF-NNNN](NNNN-locale-region-category.md)
* Proposal: [SF-0028](0028-locale-region-category.md)


* Proposal: [SF-NNNN](NNNN-locale-region-category.md)
* Authors: [Tina Liu](https://github.com/itingliu)
* Review Manager: TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Review Manager: TBD
* Review Manager: [Jeremy Schonfeld](https://github.com/jmschonfeld)

* Authors: [Tina Liu](https://github.com/itingliu)
* Review Manager: TBD
* Implementation: [https://github.com/swiftlang/swift-foundation/pull/1253]()
* Status: **Awaiting review**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Status: **Awaiting review**
* Status: **Review: Jun 11, 2025...Jun 18, 2025**

@itingliu
Copy link
Contributor Author

@swift-ci

@itingliu
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit 33cae04 into swiftlang:main Jun 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This PR is for a proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants