SF-0033: Implement `String.Encoding.ianaName` and `String.Encoding(ianaName:)`. by YOCKOW · Pull Request #1286 · swiftlang/swift-foundation

YOCKOW · 2025-05-09T07:36:50Z

Implementation of the proposal: #1243 (SF-0033)

- source: https://github.com/YOCKOW/SF-StringEncodingNameImpl

- source: https://github.com/YOCKOW/SF-StringEncodingNameImpl/blob/0.4.0/Tests/StringEncodingNameImplTests/StringEncodingNameParserTests.swift

YOCKOW · 2025-10-16T06:19:36Z

@swift-ci Please test

YOCKOW · 2025-10-16T06:55:22Z

@itingliu

I've made this PR ready for review.
I'm happy if you take a look at this. Thank you.

cc: Foundation Workgroup
@adam-fowler @iCharlesHu @Lukasa @designatednerd @jmschonfeld @lorentey @stephentyrone @itingliu @tomerd @parkera

YOCKOW · 2025-10-19T03:14:37Z

@itingliu
Thank you for reviewing. I'm going to modify implementation reflecting your feedback.

In response to: swiftlang#1286 (comment)

In response to: - swiftlang#1286 (comment) - swiftlang#1286 (comment) - swiftlang#1286 (comment)

YOCKOW · 2025-10-23T01:59:20Z

@swift-ci Please test

parkera · 2025-10-23T03:16:34Z

@swift-ci test

parkera

Looking good to me after the recent simplifications. Will also want @itingliu approval.

YOCKOW · 2025-10-23T03:35:26Z

Thank you @parkera.
I'm going to wait for @itingliu.

Just in case, what's changed:

Rewrote util script in Swift
Simplified the logic to parse names
- Use UInt8(UTF8.UnitCode)
- Remove redundant tokenizers.

itingliu

I also like this simplified version. Thank you! just had a few minor comments

itingliu · 2025-10-23T23:36:35Z

+    ///         to determine which encoding is suitable.
+    @available(FoundationPreview 6.3, *)
+    public init?(ianaName charsetName: String) {
+        let possibilities: [String.Encoding] = [


Would it work if you write

let possibilities: [IANACharset] = {...

and below just do

func __determineEncoding() -> String.Encoding? { for ianaCharset in possibilities { if ianaCharset.matches(charsetName) { return encoding } } return nil }

Am I missing anything?

Won't we lose encoding for return encoding in that implementation?

itingliu · 2025-10-23T23:38:25Z

+            return nil
+        }
+
+        guard let encoding = __determineEncoding() else {


And to simply this even further, it looks like this logic inside func __determineEncoding() doesn't even needed to be extracted in a function since it's only used once?

~~The reason why nested function is used is just because of readability since self = nil; return is invalid in Swift.~~

Sorry, we can write self = encoding; return...
I'm fixing it.

I've fixed String.Encoding(ianaName:).
I hope that this is in line with your intention.

In response to: - swiftlang#1286 (comment)

YOCKOW · 2025-10-31T05:55:37Z

@swift-ci Please test

YOCKOW · 2025-10-31T06:17:21Z

What's changed since 8f84db7:

Fixed functions' spelling
Eliminated an unnecessary nested function

itingliu

Thank you!

YOCKOW · 2025-11-11T23:39:31Z

I sincerely appreciate the reviews and approvals. Thank you so much.

YOCKOW mentioned this pull request May 9, 2025

[Proposal] Add "String Encoding Names" proposal. #1243

Merged

This comment was marked as outdated.

Sign in to view

YOCKOW added the API Change Any changes to Foundation's public API surface label May 13, 2025

YOCKOW force-pushed the StringEncodingNames/implementation branch from dd0b16c to 1ae2a4c Compare June 17, 2025 01:25

This comment was marked as outdated.

Sign in to view

YOCKOW force-pushed the StringEncodingNames/implementation branch from 1ae2a4c to 4d87ed8 Compare September 21, 2025 02:59

YOCKOW changed the title ~~Implement String.Encoding.ianaName and String.Encoding(ianaName:).~~ SF-0033: Implement String.Encoding.ianaName and String.Encoding(ianaName:). Sep 21, 2025

This comment was marked as outdated.

Sign in to view

YOCKOW force-pushed the StringEncodingNames/implementation branch 4 times, most recently from 217c46d to 9cd5c9a Compare October 12, 2025 08:16

This comment was marked as outdated.

Sign in to view

YOCKOW marked this pull request as ready for review October 14, 2025 05:27

YOCKOW marked this pull request as draft October 14, 2025 07:51

YOCKOW force-pushed the StringEncodingNames/implementation branch from 9cd5c9a to 3e9aef4 Compare October 14, 2025 08:12

YOCKOW added 9 commits October 16, 2025 15:03

Import implementation for String Encoding Names from other repo.

3bc76c0

- source: https://github.com/YOCKOW/SF-StringEncodingNameImpl

Import tests for String Encoding Names from other repo.

0ea8aff

- source: https://github.com/YOCKOW/SF-StringEncodingNameImpl/blob/0.4.0/Tests/StringEncodingNameImplTests/StringEncodingNameParserTests.swift

Remove dead code in terms of the current proposal.

7acaa40

Use Testing for String Encoding Names tests.

5563472

NFC: Fix indentation in "String+Encoding+Names.swift".

a783db1

SF-0033: Adjust comments/attributes to match the accepted proposal.

7515bf4

Auto-generate Swift source code for IANA Charset names.

c726971

Remove unnecessary @inlinable.

5c9492c

Simplify String.init(ianaName:).

ac42127

YOCKOW force-pushed the StringEncodingNames/implementation branch from 3e9aef4 to ac42127 Compare October 16, 2025 06:04

Add new files related to SF-0033 to CMakeLists.txt.

c7bdbef

YOCKOW marked this pull request as ready for review October 16, 2025 06:55

YOCKOW requested a review from itingliu October 16, 2025 06:55

itingliu reviewed Oct 18, 2025

View reviewed changes

YOCKOW added a commit to YOCKOW/swift-foundation that referenced this pull request Oct 19, 2025

Rewrite script in Swift instead of Python.

0045a48

In response to: swiftlang#1286 (comment)

Rewrite script in Swift instead of Python.

e674fa6

In response to: swiftlang#1286 (comment)

YOCKOW force-pushed the StringEncodingNames/implementation branch from 0045a48 to e674fa6 Compare October 19, 2025 08:55

YOCKOW added a commit to YOCKOW/swift-foundation that referenced this pull request Oct 22, 2025

Simplify logic to parse IANA Charset names.

b7702b3

In response to: - swiftlang#1286 (comment) - swiftlang#1286 (comment) - swiftlang#1286 (comment)

Simplify logic to parse IANA Charset names.

8f84db7

In response to: - swiftlang#1286 (comment) - swiftlang#1286 (comment) - swiftlang#1286 (comment)

YOCKOW force-pushed the StringEncodingNames/implementation branch from b7702b3 to 8f84db7 Compare October 22, 2025 02:31

parkera approved these changes Oct 23, 2025

View reviewed changes

itingliu reviewed Oct 23, 2025

View reviewed changes

YOCKOW added 2 commits October 24, 2025 11:27

Fix spelling of functions for "case-insensitively".

d4ab876

In response to: - swiftlang#1286 (comment)

Remove redundant nested function in String.Encoding(ianaName:).

cf9ed49

In response to: - swiftlang#1286 (comment)

YOCKOW requested a review from itingliu October 31, 2025 06:17

itingliu approved these changes Nov 4, 2025

View reviewed changes

YOCKOW merged commit d8533a2 into swiftlang:main Nov 11, 2025
21 checks passed

Conversation

YOCKOW commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

YOCKOW commented Oct 16, 2025

Uh oh!

YOCKOW commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YOCKOW commented Oct 19, 2025

Uh oh!

YOCKOW commented Oct 23, 2025

Uh oh!

parkera commented Oct 23, 2025

Uh oh!

parkera left a comment

Choose a reason for hiding this comment

Uh oh!

YOCKOW commented Oct 23, 2025

Uh oh!

itingliu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

itingliu Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YOCKOW Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

itingliu Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YOCKOW Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YOCKOW Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

YOCKOW commented Oct 31, 2025

Uh oh!

YOCKOW commented Oct 31, 2025

Uh oh!

itingliu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

YOCKOW commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YOCKOW commented May 9, 2025 •

edited

Loading

itingliu Oct 23, 2025 •

edited

Loading

itingliu Oct 23, 2025 •

edited

Loading

YOCKOW Oct 24, 2025 •

edited

Loading