Add tests for AttributedString Index Tracking preconditions #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Looks like we can't currently land the new tests on Windows because the latest toolchain is a few months old and doesn't have exit test support |
|
@swift-ci please test |
jmschonfeld
force-pushed
the
index-tracking-precondition-tests
branch
from
2369930 to
5967832
Compare
|
@swift-ci please test |
|
@swift-ci please test |
itingliu
approved these changes
Jun 4, 2025
jckarter
pushed a commit
that referenced
this pull request
Jun 6, 2025
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Jun 6, 2025
…itions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199.
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Jun 6, 2025
…itions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199.
jmschonfeld
added a commit
that referenced
this pull request
Jun 9, 2025
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 10, 2025
…g#1326) * Convert test to Swift Testing * Add additional exit test for preconditions * Add FOUNDATION_EXIT_TESTS conditional * Fix build failure
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 10, 2025
…wiftlang#1326)" (swiftlang#1337) This reverts commit 226ba0a.
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 10, 2025
…ng#1338) * Revert "Revert "Add tests for AttributedString Index Tracking preconditions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199. * Disable exit tests on Ubuntu 20.04 for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new
AttributedStringtransform(updating:)functions, there are a variety ofpreconditions that validate the provided input. With XCTest we previously did not have a way to test these preconditions, but now swift-testing has support for exist tests in Swift 6.2. This change migrates the existingAttributedStringIndexTrackingTestssuite from XCTest to swift-testing and adds two additional tests to fully cover the preconditions and expected crashes for this API.