[6.2] include <stdnoreturn.h> last#1333
Closed
Steelskin wants to merge 1 commit intoswiftlang:release/6.2from
Closed
[6.2] include <stdnoreturn.h> last#1333Steelskin wants to merge 1 commit intoswiftlang:release/6.2from
<stdnoreturn.h> last#1333Steelskin wants to merge 1 commit intoswiftlang:release/6.2from
Conversation
Starting with the Windows SDK 10.0.26100.3916, inclusion of `<stdnoreturn.h>` clashes with some of the definitions in other ucrt headers. Move `<stdnoreturn.h>` to be last to work around this issue.
Member
|
@swift-ci please smoke test |
Member
|
@swift-ci please test |
Steelskin
changed the title
<stdnoreturn> last<stdnoreturn.h> last
compnerd
approved these changes
Jul 31, 2025
Member
|
This has already been merged into 6.2 - any reason to keep this @Steelskin? |
Contributor
Author
I did not realize that. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the Windows SDK 10.0.26100.3916, inclusion of
<stdnoreturn.h>clashes with some of the definitions in other ucrt headers. Move<stdnoreturn.h>to be last to work around this issue.Limited to the include order in one file.
N/A
Include
<stdnoreturn.h>last #1330<stdnoreturn.h>is not a requirement for any of the other headers in this file, so the risk is minimalLocal build with a 10.0.26100.3916 Windows SDK
@compnerd