Skip to content

Adopt swift-testing for AttributedString tests #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2025

Conversation

jmschonfeld
Copy link
Contributor

This adopts swift-testing for all of the AttributedString test suites. This paves the way for adding new capabilities to our AttributedString tests, such as adding exit tests to support validating all of our preconditions related to index validation (I'll post a followup PR that adds these new tests as I've noticed that when adding the tests, we have quite a few behavioral bugs that we should fix when adding these tests.

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit 276dd51 into swiftlang:main Jun 9, 2025
15 checks passed
@jmschonfeld jmschonfeld deleted the attrstr/swift-testing branch June 9, 2025 19:32
chloe-yeo pushed a commit to chloe-yeo/swift-foundation that referenced this pull request Jun 10, 2025
* Convert CoW tests to swift-testing

* Convert discontiguous tests to swift-testing

* Convert index validity tests to swift-testing

* Convert constraining behavior tests to swift-testing

* Convert base attributed string tests to swift-testing

* Fix build failure

* Fix test crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants