Reenable AttributedString index tracking swift testing tests#1338
Merged
jmschonfeld merged 2 commits intoswiftlang:mainfrom Jun 9, 2025
Merged
Reenable AttributedString index tracking swift testing tests#1338jmschonfeld merged 2 commits intoswiftlang:mainfrom
jmschonfeld merged 2 commits intoswiftlang:mainfrom
Conversation
…itions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199.
Contributor
Author
|
@swift-ci please test |
jmschonfeld
force-pushed
the
reenable-swift-testing-tests
branch
from
71f5b6f to
dbe20fc
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Confirmed that with this PR, swift foundation tests pass in the full toolchain CI run |
parkera
approved these changes
Jun 9, 2025
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 10, 2025
…ng#1338) * Revert "Revert "Add tests for AttributedString Index Tracking preconditions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199. * Disable exit tests on Ubuntu 20.04 for now
chloe-yeo
pushed a commit
to chloe-yeo/swift-foundation
that referenced
this pull request
Jun 16, 2025
…ng#1338) * Revert "Revert "Add tests for AttributedString Index Tracking preconditions (swiftlang#1326)" (swiftlang#1337)" This reverts commit 2df5199. * Disable exit tests on Ubuntu 20.04 for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the revert performed in #1337 (which was done to recover the swift repo's CI which began failing on Linux due to the tests hanging) and disables
FOUNDATION_EXIT_TESTSon Ubuntu 20.04. Exit tests currently hang indefinitely on 20.04 (swiftlang/swift-testing#1140) (which is what the swift repo's CI uses for full toolchain tests) while Ubuntu 22.04 (which is what this repo's CI uses) works fine.