FoundationEssentials,FoundationInternationalization: adjust for aliasing#1340
FoundationEssentials,FoundationInternationalization: adjust for aliasing#1340compnerd merged 1 commit intoswiftlang:mainfrom
Conversation
itingliu
left a comment
itingliu
left a comment
There was a problem hiding this comment.
The ICU related parts look good to me
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test |
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test |
|
This should really go in with the ICU changes IMO. This is one of the last pieces needed to start exploring building the early swift-driver on Windows. |
|
@compnerd do you want to handle synchronizing the merge of these two PRs when you are ready? |
|
@parkera thanks! yeap - I'll go ahead and synchronise these two |
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.
|
Cross-repo tested at https://ci-external.swift.org/job/swift-PR-windows/42872/ |
|
Please test with following PRs: @swift-ci please test |
4 participants
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.