Add an implementation of the UTCClock and associated tests #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jmschonfeld
reviewed
Jun 10, 2025
| #endif | ||
|
|
||
| #if canImport(FoundationEssentials) | ||
| @testable import FoundationEssentials |
There was a problem hiding this comment.
Does this test need a @testable import? If not, I think you can remove this. If it does, I think you'll want an #else branch that has @testable import Foundation to make sure this works for FOUNDATION_FRAMEWORK where FoundationEssentials doesn't exist
|
Can the empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the proposal #1342