Generalize Data's withUnsafe[Mutable]Bytes functions#1622
Merged
glessard merged 3 commits intoswiftlang:mainfrom Mar 24, 2026
Merged
Generalize Data's withUnsafe[Mutable]Bytes functions#1622glessard merged 3 commits intoswiftlang:mainfrom
withUnsafe[Mutable]Bytes functions#1622glessard merged 3 commits intoswiftlang:mainfrom
Conversation
Contributor
glessard
commented
Dec 4, 2025
glessard
commented
- Support typed throws
- Support non-copyable return values
Contributor
Author
|
@swift-ci please test |
jmschonfeld
reviewed
Dec 4, 2025
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
jmschonfeld
reviewed
Dec 5, 2025
Contributor
Author
|
@swift-ci please test |
jmschonfeld
approved these changes
Dec 5, 2025
Contributor
Author
|
@swift-ci please test |
glessard
force-pushed
the
data+generalized-with-unsafe-bytes
branch
from
c6f7a4f to
6ab735c
Compare
Contributor
Author
|
@swift-ci please test |
jmschonfeld
approved these changes
Dec 11, 2025
Tweak a test (silence a warning) Generalize Data’s `withUnsafeMutableBytes` functions Test generalized functions Only compile old ABI for FOUNDATION_FRAMEWORK Verify the old ABI Spell `rethrows` as `throws` in ABI-compatibility functions Improve test by using a more specific #expect Add a test suite specifically for legacy ABI tests Generalize `withContiguousStorageIfAvailable` as well
jmschonfeld
force-pushed
the
data+generalized-with-unsafe-bytes
branch
from
6ab735c to
db58f28
Compare
itingliu
approved these changes
Mar 10, 2026
Contributor
|
@swift-ci please test |
itingliu
approved these changes
Mar 10, 2026
- Use `@inline(__always)` with `@_aeic` - Use DATA_LEGACY_ABI instead of FOUNDATION_FRAMEWORK. They have different semantics. Targets requiring data legacy ABI don't always build with FOUNDATION_FRAMEWORK. - Fix copy pasta errors in tests.
Contributor
|
@swift-ci please test |
glessard
commented
Mar 24, 2026
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.