GetUserNameExW returns 0 on error, non-zero on success#1642
Open
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Open
GetUserNameExW returns 0 on error, non-zero on success#1642SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Conversation
jmschonfeld
reviewed
Dec 16, 2025
SiliconA-Z
force-pushed
the
guard-wrong
branch
2 times, most recently
from
9b99a45 to
274e0ca
Compare
I know Microsoft is not consistent on this, but yes.
SiliconA-Z
force-pushed
the
guard-wrong
branch
from
274e0ca to
6e50926
Compare
jmschonfeld
reviewed
Dec 18, 2025
| } | ||
|
|
||
| #if os(macOS) | ||
| #if canImport(Darwin) || os(Windows) |
Contributor
There was a problem hiding this comment.
It looks like when adding the Windows conditional here you also changed the macOS conditional to canImport(Darwin) - was there a reason for that? This will fail to build on platforms like iOS because ProcessInfo.userName is unavailable on those platforms
itingliu
requested changes
Jan 13, 2026
Contributor
itingliu
left a comment
itingliu
left a comment
There was a problem hiding this comment.
Unfortunately we don't have an IOS CI, but I agree with Jeremy that the test won't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know Microsoft is not consistent on this, but GetUserNameExW returns 0 on error.