GetLastError() doesn't return anything if the call succeeds#1646
Open
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Open
GetLastError() doesn't return anything if the call succeeds#1646SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Conversation
itingliu
previously requested changes
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Can you add a description of this PR? Please feel free to refer to the PR template for what's to include.
Changed GetLastError() to ERROR_ALREADY_EXISTS when destination file exists check succeeds.
itingliu
previously requested changes
Jan 13, 2026
Contributor
itingliu
left a comment
itingliu
left a comment
There was a problem hiding this comment.
But meanwhile can we add a test for this?
itingliu
dismissed
their stale review
Given that this is a real bug from code inspection, I think it's fair to merge it
Contributor
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed GetLastError() to ERROR_ALREADY_EXISTS when destination file exists check succeeds.