Use st_birthtimespec instead of st_ctim.tv_sec on Darwin#1648
Open
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Open
Use st_birthtimespec instead of st_ctim.tv_sec on Darwin#1648SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Conversation
st_ctim records the last time the inode changed. Closest thing on linux, but st_birthtimespec is what we actually want here.
jmschonfeld
reviewed
Jan 14, 2026
| } | ||
| #endif | ||
|
|
||
| @Test(.enabled(if: isDarwin, "Birth time is only exposed on Darwin")) |
Contributor
There was a problem hiding this comment.
Is there a reason that we should limit this test to Darwin platforms? I know Darwin platforms are the ones that don't pass this test today, but we should expect platforms like Linux and Windows to pass this test as well, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
st_ctim records the last time the inode changed. Closest thing on linux, but st_birthtimespec is what we actually want here.