Avoid getattrlist TOCTOU issue for atomic file writing#1805
Merged
jmschonfeld merged 1 commit intoswiftlang:mainfrom Mar 10, 2026
Merged
Avoid getattrlist TOCTOU issue for atomic file writing#1805jmschonfeld merged 1 commit intoswiftlang:mainfrom
jmschonfeld merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
kperryua
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use FSOPT_UNIQUE in getattrlist when writing files atomically
Motivation:
getattrlistcan provide stale information due to TOCTOU behavior exhibited by the kernel. To avoid this issue, we can useFSOPT_UNIQUEto have the kernel fail for us if there are multiple hard link locations rather than checking the returned data ourselvesModifications:
Adds
FSOPT_UNIQUEto thegetattrlistcalls in data atomic writing and remove thenlinkcheck of the resultResult:
We no longer read potentially stale information from the
getattrlistresultTesting:
This is a small window for a race condition in the kernel that is not deterministically testable. It is also in
FOUNDATION_FRAMEWORKcode