Skip to content

Re-enable encodeBytes(_:[UInt8]) implementation #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kperryua merged 1 commit into from
Mar 16, 2026
Merged

Re-enable encodeBytes(_:[UInt8]) implementation #1821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Sources/NewCodable/JSON/NewJSONEncoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,15 +434,7 @@ public struct JSONDirectEncoder: CommonEncoder, ~Copyable, ~Escapable {

@_lifetime(self: copy self)
public mutating func encodeBytes(_ bytes: [UInt8]) throws(CodingError.Encoding) {
fatalError("TODO: Disabled to allow the compiler to work??")
// do {
// try bytes.withUnsafeBytes { ptr throws(CodingError.Encoding) in
// try self.encodeBytes(ptr, count: ptr.count)
// }
// } catch {
// // TODO: Fix unsavory workaround
// throw error as! CodingError.Encoding
// }
try self.encodeBytes(bytes.span.bytes)
}

@_lifetime(self: copy self)
Expand Down
Loading