Fix Data.WritingOptions SetAlgebra semantics violations#1822
Merged
jmschonfeld merged 2 commits intoswiftlang:mainfrom Mar 16, 2026
Merged
Fix Data.WritingOptions SetAlgebra semantics violations#1822jmschonfeld merged 2 commits intoswiftlang:mainfrom
jmschonfeld merged 2 commits intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
kperryua
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect semantics of
Data.WritingOptionsSetAlgebraoperationsMotivation:
Data.WritingOptionsdoes not follow the semantic requirements ofSetAlgebra. Notably, the file protection part is anenumvalue (zero or one may be selected, not multiple) and so the existing bit mask-based arithmetic on these values is not correct. This causes unexpected results when using operations like.containsModifications:
Add AEIC versions of each broken
SetAlgebrafunction providing better behavior when possibleResult:
Data.WritingOptionsnow behaves as you'd expect and abides by allSetAlgebrasemantic constraints. The only slightly problematic behavior remaining is fromformUnion- it is not possible to form a union between two option sets that both contain file protection parts, so we only keep one of them.Testing:
Added new unit tests that run exhaustive conformance validation tests as well as targeted tests of common expected use patterns.