Add @discardableResult to Data.WritingOptions concrete implementations#1856
Merged
jmschonfeld merged 1 commit intoswiftlang:mainfrom Mar 27, 2026
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
@discardableResultannotations to the new concrete implementations ofData.WritingOptionsSetAlgebraAPIsMotivation:
Some
SetAlgebraAPIs that I recently implemented inData.WritingOptionshad@discardableResultbut my implementations are missing that annotation. This means that callers start seeing warnings when discarding the result that were not present before.Modifications:
Add
@discardableResultto the new implementationsResult:
Clients no longer see warnings when discarding the result of these functions
Testing:
It is not possible to test for the presence of this specific warning in a unit test, this change has been manually tested