Skip LargeDataTests when memory limits are small#1861
Merged
jmschonfeld merged 1 commit intoswiftlang:mainfrom Mar 28, 2026
Merged
Skip LargeDataTests when memory limits are small#1861jmschonfeld merged 1 commit intoswiftlang:mainfrom
jmschonfeld merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
glessard
approved these changes
Mar 28, 2026
Contributor
glessard
left a comment
glessard
left a comment
There was a problem hiding this comment.
I agree this is the best option we have at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LargeDataTests uses a large amount of memory, so we should skip it when the memory limits are too constrained
Motivation:
On some platforms like iOS, there may be memory limits beyond just the memory available to the device that could prevent us from making large allocations. We should avoid running these tests when limits are in place
Modifications:
Use
os_proc_available_memoryto avoid running tests when memory limits are too constrainedResult:
Tests do not crash when memory limits are in place
Testing:
This is a unit test change