Initializers for joining a sequence of predicates#1878
Open
MatthewTurk247 wants to merge 1 commit intoswiftlang:mainfrom
Open
Initializers for joining a sequence of predicates#1878MatthewTurk247 wants to merge 1 commit intoswiftlang:mainfrom
MatthewTurk247 wants to merge 1 commit intoswiftlang:mainfrom
Conversation
jmschonfeld
reviewed
Apr 6, 2026
| } | ||
|
|
||
| @Test func all() throws { | ||
| #expect(try Predicate(all: []).evaluate(42)) |
Contributor
There was a problem hiding this comment.
I'm actually a bit surprised this compiles without telling it what the Input type of the predicate is here. Does it infer an input of type Int from the call to evaluate using the type of 42?
| #expect(try !Predicate(all: predicates).evaluate(input)) | ||
| predicates.append(#Predicate { $0.c < 0.0 }) | ||
| #expect(try !Predicate(all: predicates).evaluate(input)) | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add tests that validate the short circuiting behavior to validate that predicates later in the list aren't evaluated if a prior expression fails? This should be possible with a custom object and a property (referenced in the predicate via a keypath) that records when the property is accessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the initializers proposed in #1860.
Testing:
See
PredicateTests/all()andPredicateTests/any().