Allow semicolon in file path for Swift URL v2#1882
Merged
jrflat merged 2 commits intoswiftlang:mainfrom Apr 9, 2026
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
itingliu
approved these changes
Apr 9, 2026
Contributor
|
I think the current failing SwiftPM failures would be gone if you rebase |
jrflat
force-pushed
the
url-file-path-semicolon
branch
from
11e1e30 to
c352fa2
Compare
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintain behavior of not encoding
;in theURL(filePath:)initializers when v2 is enabled.Motivation:
NSURLandCFURLfile path initializers encode semicolons in the path, butURLcurrently doesn't, and neither do any modern parsers. When using the shared code, we should still maintain the modern behavior forURL.Modifications:
Plumb a
compatibility: Boolthrough the respective functions to maintain the behavior whenFOUNDATION_SWIFT_URL_V2is enabled.Result:
No behavior difference from current
URLimplementation (;is allowed unencoded).Testing:
Added unit test to ensure non-encoding behavior of
;forURLfile path APIs. AddedNSURLunit tests to ensure we maintain its behavior of encoding;in the file path for compatibility.