Implement 'withoutEscapingSlashes' option and clean up string writing#1885
Merged
kperryua merged 1 commit intoswiftlang:experimental/new-codablefrom Apr 8, 2026
Conversation
Contributor
Author
|
Test failures are unrelated time zone issues or the extant Windows crash. |
kperryua
merged commit ad819dc
into
swiftlang:experimental/new-codable
17 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
withoutEscapingSlashesoption.Motivation:
The
withoutEscapingSlashesoption had not been implemented or tested as yet.Modifications:
Make the escape tables used in the algorithm properties of the JSONWriter, switching between the two options on
init().Also includes some opportunistic cleanup of the JSON string writing function.
Result:
The behavior is now implemented properly.
Testing:
Added a simple test case that demonstrates forward slashes NOT being escaped when
withoutEscapingSlashes:true