Mark legacy ABI as obsoleted rather than as spi#1905
Merged
glessard merged 1 commit intoswiftlang:mainfrom Apr 15, 2026
Merged
Conversation
Addresses rdar://174193354
jmschonfeld
approved these changes
Apr 14, 2026
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses rdar://174193354
Using the
@_spiannotation causes validation issues with the Foundation framework. We can useobsoletedannotations instead, at the cost of less straightforward testing. I took advantage of the process of figuring out these tests to round out the legacy ABI tests.