[6.0] Fix file URL in test-static-stdlib#144
Merged
jrflat merged 1 commit intoswiftlang:release/6.0from Jul 29, 2024
Merged
Conversation
parkera
approved these changes
Jul 29, 2024
MaxDesiatov
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #143 for release/6.0
Explanation: Updates the test so that it will pass with new swift-foundation
URL(fileURLWithPath:)behavior that no longer removes consecutive slashes. This matches the behavior of all common RFC 3986 and WHATWG parsers, but caused this test to fail onmainandrelease/6.0.Scope: Affects a single test run during package testing
Original PR: #143
Risk: Minimal - minor test-only change that is backwards and forwards compatible with the old swift-corelibs-foundation and new swift-foundation URL behavior
Testing: Swift smoke tests including branch
Reviewer: @etcwilde