Improve nested names handling even in #if scopes#823
Merged
Conversation
llsc12
added a commit
to llsc12/swift-java
that referenced
this pull request
Jul 9, 2026
Cherry-picked from swiftlang#823 (ktoso). Nested type/typealias members wrapped in an #if/#else were never visited when building the per-parent nested-type map, since the member-walk only checked for a direct nominal or typealias decl and skipped IfConfigDeclSyntax entirely - so such a type was invisible to lookups needing its parent, same class of symptom as the extension-declared case fixed in cf5bd53, but a genuinely separate gap (verified empirically: this PR alone, without cf5bd53, does not fix the original extension-based repro - the two fixes are complementary, not overlapping).
This also resolves swiftlang#822 while at it
Collaborator
Author
|
Also handling the extension case better now, thanks @llsc12! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also resolves #822 while at it