-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use swiftly_release data for the download page #873
Open
cmcgee1024
wants to merge
122
commits into
swiftlang:swiftly-preview
Choose a base branch
from
cmcgee1024:swiftly-preview
base: swiftly-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use swiftly_release data for the download page #873
cmcgee1024
wants to merge
122
commits into
swiftlang:swiftly-preview
from
cmcgee1024:swiftly-preview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo in the Writing a Patch - A good patch is section.
`cmp.visual()` should be `cmp.visible()`.
Instruct users to install the MSVC ARM64 tools when installing Visual Studio. This should ensure that cross-compilation is possible (and native compilation when on ARM64). Fixes: swiftlang#839
* Separate instructions for older installers * Settle on Python 3.9 as recommended release
… toolchains to the install page (swiftlang#852)
* Update dependencies * Fix SASS errors
…swiftly_release.yml with the latest release
Whenever swiftly publishes a new release and updates the API then the website should direct everyone to that new release in both the instructions and the download URLs.
cmcgee1024
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
January 18, 2025 20:23
…ite into swiftly-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the download pages for Linux and macOS so that they use the swiftly_release information to get the latest swiftly version to set the URL's and instructions.
Motivation:
We would like to use the API to automatically populate the swiftly information when a new release is made instead of having to update the Linux and macOS pages each time.
Modifications:
Pulled in the latest commits from main with the swiftly release API.
Result:
The change will automatically set the URLs and instructions relating to the swiftly version.