Introduce support for Clang/Swift compilation caching#10246
Open
owenv wants to merge 1 commit into
Open
Conversation
Contributor
|
Generally LGTM. I don't mind just set explicit module by default in caching so there won't be a dependency on swift-build change. Can we also wire up following swift-build config to a swiftpm argument?
|
owenv
force-pushed
the
owenv/compilationcaching
branch
2 times, most recently
from
bcba441 to
c987fa5
Compare
owenv
force-pushed
the
owenv/compilationcaching
branch
from
c987fa5 to
0be7994
Compare
owenv
changed the title
Contributor
Author
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
bkhouri
reviewed
Jul 6, 2026
|
|
||
| // MARK: - Build cache | ||
|
|
||
| extension Workspace.Configuration { |
Contributor
There was a problem hiding this comment.
suggestion: Can we can automated tests that verify the newly added Workspace.Configuration code in isolation?
Contributor
Author
There was a problem hiding this comment.
IMO this would be mostly redundant
owenv
force-pushed
the
owenv/compilationcaching
branch
from
0be7994 to
42dcdab
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
cachemeifyoucan
approved these changes
Jul 9, 2026
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
Contributor
There was a problem hiding this comment.
I checked the config and build parameters. LGTM.
Only nit is if we need to warn if people selecting compilation cache and a non-swift-build build system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for Clang/Swift compilation caching integration as described in the draft evolution proposal at https://gist.github.com/owenv/4d0f48e30df77a418eea1968223e8033
Caching can be configured either via CLI options of package-local/global configuration. Internally, it maps to Swift Build settings overrides which enable the feature in the underlying build system