Add binary type for binary targets to add-target command.
#8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantjbutler
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
|
@swift-ci please test |
hi2gage
reviewed
Mar 12, 2025
| """ | ||
| ) | ||
|
|
||
| _ = try await execute(["add-target", "client", "--url", "https://example.com/client.xcframework.zip", "--checksum", "abcdef1234567890", "--type", "binary"], packagePath: path) |
There was a problem hiding this comment.
Would it make sense to add checksum validation to ensure that the user is inputting a valid SHA-256 checksum? As called out in PackageDescription.Target.checksum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
add-targetsubcommand to allow creating a target that references a remote or local binary artifact.Motivation:
The
add-targetcommand currently accepts a set of arguments that make it seem like it should be able to create a.binaryTargetin the package's manifest. However, when trying to use the command in this way, you'll either get an error because of validation if trying to create a target for a remote binary artifact, or a regular source target will be created if trying to create a target for a local binary artifact. Issue #8277 has the full details.Modifications:
This PR adds
.binaryas a new value for theTargetTypeenum (which is used for parsing the--typeargument of theadd-targetcommand). This value gets mapped toTargetDescription.TargetKind.binarywhen actually creating the target in the manifest.Result:
By specifying
--type binaryfor theadd-targetcommand and providing a value for--urlor--path, a.binaryTargetwill be added to the package's manifest, with the appropriate configuration depending on if the binary artifact is sourced from a remote URL or a local path.