Remove usages of deprecated registry methods #8335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the remainder of the PackageRegistry code to be async first, and move existing usages of the old sync methods in PackageRegistryCommand over to the new async alternatives. Clean up unnecessary plumbing of callbackQueues through the async methods.
plemarquand
force-pushed
the
fix-async-registry-warnings
branch
from
8066970 to
552932c
Compare
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
owenv and
bkhouri
as code owners
plemarquand
commented
Mar 7, 2025
Sources/Workspace/PackageContainer/RegistryPackageContainer.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
|
@swift-ci please test windows |
|
@swift-ci please test |
bripeticca
reviewed
Mar 25, 2025
|
@swift-ci please test |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix the warnings around using the sync versions of PackageRegistry methods.
Modifications:
Convert the remainder of the PackageRegistry code to be async first, and move existing usages of the old sync methods in PackageRegistryCommand over to the new async alternatives. Clean up unnecessary plumbing of callbackQueues through the async methods.
Result:
All asynchronous methods are
asyncbased inside Sources/PackageRegistry, and warnings about using deprecated methods have been fixed.