SwiftBuild: add scratch path symbolic links#9972
Draft
bkhouri wants to merge 1 commit intoswiftlang:mainfrom
Draft
SwiftBuild: add scratch path symbolic links#9972bkhouri wants to merge 1 commit intoswiftlang:mainfrom
bkhouri wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci test |
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
dfb458b to
32ad9aa
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
32ad9aa to
7439fdd
Compare
Contributor
Author
|
@swift-ci test |
owenv
reviewed
Apr 22, 2026
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
7439fdd to
1914e8d
Compare
Contributor
Author
Contributor
Author
|
@swift-ci test windows |
Member
|
My first thought is that it would be nice to do this outside the build system. Show bin path works right from the command state and you have everything you need there. It's just looks awkward having to pass in the scratch path directory all the way down just to create the link. But that's more a code cleanliness thing. |
Member
|
That said buildSystem.build is called from all over the place in SwiftPM so that may be hard to do. |
plemarquand
requested changes
Apr 22, 2026
Contributor
plemarquand
left a comment
plemarquand
left a comment
There was a problem hiding this comment.
Can you add some tests to validate this new behaviour?
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
1914e8d to
71cc845
Compare
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
71cc845 to
c4bdb31
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
The native build system would create the `debug` and `release` symbolic link in the scratch path as they were the original output location before triple support was added. Although this is not an officially support feature, add the `debug` and `release` symbolic links when using Swift Build to ease the transition until a better solution is avaiable. Relates to: swiftlang#9963 Issue: rdar://175144467
bkhouri
force-pushed
the
t/main/gh9963_rdar175144467_preserve_symlinks
branch
from
c4bdb31 to
6b7a3ab
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
plemarquand
approved these changes
Apr 23, 2026
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native build system would create the
debugandreleasesymbolic link in the scratch path as they were the original output location before triple support was added.Although this is not an officially support feature, add the
debugandreleasesymbolic links when using Swift Build to ease the transition until a better solution is avaiable.Fixes: #9963
Issue: rdar://175144467
Merge with: swiftlang/sourcekit-lsp#2620 (passed) or with swiftlang/sourcekit-lsp#2621 (testing in progress)