Skip to content

Run all request kinds by default#155

Open
bnbarham wants to merge 1 commit into
swiftlang:mainfrom
bnbarham:run-test-modules-by-default
Open

Run all request kinds by default#155
bnbarham wants to merge 1 commit into
swiftlang:mainfrom
bnbarham:run-test-modules-by-default

Conversation

@bnbarham

Copy link
Copy Markdown
Contributor

Start running the test modules request as well.

@ahoppen

ahoppen commented Jun 10, 2021

Copy link
Copy Markdown
Member

As discussed offline, I would like to hold this back until I’ve merged #146.

@ahoppen

ahoppen commented Aug 5, 2021

Copy link
Copy Markdown
Member

@ahoppen

ahoppen commented Nov 18, 2021

Copy link
Copy Markdown
Member

Triggered a stress tester run in swiftlang/swift#37710.

@ahoppen

ahoppen commented Nov 22, 2021

Copy link
Copy Markdown
Member

Between some unrelated failures, the stress tester has found a few module issues as well. I think that shows that having the stress tester test modules has a benefit, even though it increases the run time by 4 hours (previously 10 hours, now 14 hours).

Once the failures are fixed I’m OK with merging this.

@ahoppen

ahoppen commented Feb 25, 2022

Copy link
Copy Markdown
Member

@swift-ci Please test

@ahoppen ahoppen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/8/console only made a few code completion timeouts re-appear. I’m fine with merging this as-is. I’ll take care of xfailing the timeout issues when the start appearing in the nightly jobs.

@bnbarham

Copy link
Copy Markdown
Contributor Author

@swift-ci please test

1 similar comment
@shahmishal

Copy link
Copy Markdown
Member

@swift-ci please test

@bnbarham

Copy link
Copy Markdown
Contributor Author

The latest run was successful. Given it hasn't run for a few months, I'm not convinced that it's worth the extra 2 hours to run this as well. Might just manually run every now and again, then reconsider if this does find any extra issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants