Run all request kinds by default#155
Conversation
|
As discussed offline, I would like to hold this back until I’ve merged #146. |
|
Stress tester run: https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/52/ |
|
Triggered a stress tester run in swiftlang/swift#37710. |
|
Between some unrelated failures, the stress tester has found a few module issues as well. I think that shows that having the stress tester test modules has a benefit, even though it increases the run time by 4 hours (previously 10 hours, now 14 hours). Once the failures are fixed I’m OK with merging this. |
|
@swift-ci Please test |
ahoppen
left a comment
There was a problem hiding this comment.
https://ci.swift.org/job/swift-PR-macos-with-sourcekit-stress-tester/8/console only made a few code completion timeouts re-appear. I’m fine with merging this as-is. I’ll take care of xfailing the timeout issues when the start appearing in the nightly jobs.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
The latest run was successful. Given it hasn't run for a few months, I'm not convinced that it's worth the extra 2 hours to run this as well. Might just manually run every now and again, then reconsider if this does find any extra issues. |
Start running the test modules request as well.