docs: fix typos and copy-paste error in LSP/BSP comments - #68
Merged
Conversation
Fix 13 issues across LSP and BSP protocol type documentation: - Fix "subsequent in report" → "subsequent report" in WorkDoneProgressBegin/Report - Fix "don't support control" → "don't support controlling" in WorkDoneProgressReport - Fix "indicating to for example indicate" → "indicating, for example," in WorkDoneProgressEnd - Fix incorrect debug description "WorkDoneProgressReport" → "WorkDoneProgressEnd" - Fix "has trigger code complete" → "has triggered code completion" in CompletionContext - Fix "multiple signature" → "multiple signatures" in SignatureHelp - Fix "is ignore if" → "is ignored if" in SignatureHelp - Fix "as no signatures" → "has no signatures" in SignatureHelp - Fix extra backtick in build/taskStart reference - Fix "The was not" → "The test was not" in TestStatus.skipped - Fix trailing space before period and missing period in Deprecated comments
Avicennasis
requested review from
ahoppen,
hamishknight,
owenv and
rintaro
as code owners
June 23, 2026 16:23
hamishknight
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 13 documentation issues across 4 files in the LSP and BSP protocol types:
WorkDoneProgress.swift:
WorkDoneProgressBeginandWorkDoneProgressReport)debugDescriptioninWorkDoneProgressEnddecoder: referencedWorkDoneProgressReportinstead ofWorkDoneProgressEndCompletionRequest.swift:
SignatureHelpRequest.swift:
TaskFinishNotification.swift:
`build/taskStart`referenceTestStatus.skippedCompileReportData.originIddeprecation commentTestReportData.originIddeprecation commentNo functional changes — all fixes are in doc comments except the
debugDescriptionstring correction inWorkDoneProgressEnd, which fixes a potentially misleading error message.