[Sema] Improve diagnoses of generic specializations#75526
Merged
xedin merged 1 commit intoswiftlang:mainfrom Jul 31, 2024
Merged
[Sema] Improve diagnoses of generic specializations#75526xedin merged 1 commit intoswiftlang:mainfrom
xedin merged 1 commit intoswiftlang:mainfrom
Conversation
gregomni
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov,
tshortli and
xedin
as code owners
Contributor
Author
|
@swift-ci Please test source compatibility. |
Contributor
Author
|
@swift-ci Please smoke test. |
Contributor
Author
|
Looks like smoke test failed because of this test: swiftlang/swift-integration-tests#143 @swift-ci Please smoke test. |
Contributor
Author
|
@swift-ci Please smoke test. |
xedin
requested changes
Jul 29, 2024
Contributor
Author
|
Added warning for macros and then squashed. @swift-ci Please smoke test. |
Contributor
Author
|
@swift-ci Please smoke test. |
xedin
reviewed
Jul 30, 2024
Contributor
Author
|
@swift-ci Please smoke test. |
xedin
reviewed
Jul 30, 2024
Always add constraints, find fixes during simplify. New separate fix for allow generic function specialization. Improve parse heuristic for isGenericTypeDisambiguatingToken. Degrade concrete type specialization fix to warning for macros.
Contributor
Author
|
@swift-ci Please smoke test. |
Contributor
|
Let's run source compat, just in case. |
Contributor
|
@swift-ci please test source compatibility |
Contributor
|
I want to see how that warning looks like now in penny-bot project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplication of PR #74909 (which got rolled back) along with PR #75463. Reapplied to up-to-date main branch and an addition to work around issue #75500.