[Concurrency] Adopt typed throws in Task creation APIs#86358
Closed
mattmassicotte wants to merge 3 commits intoswiftlang:mainfrom
Closed
[Concurrency] Adopt typed throws in Task creation APIs#86358mattmassicotte wants to merge 3 commits intoswiftlang:mainfrom
mattmassicotte wants to merge 3 commits intoswiftlang:mainfrom
Conversation
Contributor
|
@swift-ci please smoke test |
Contributor
Author
|
smoke test failed because the change introduced a compiler crash when compiling "swift-tools-protocols" |
Contributor
|
Depends on #86400 |
mattmassicotte
force-pushed
the
feature/task-init-improvements
branch
from
249d3aa to
7ed8442
Compare
Contributor
|
@swift-ci please smoke test |
Contributor
Author
|
I've now rebased against main to pick up the fix from #86400 |
Contributor
Author
|
Failure on Windows, x86_64-unknown-windows-msvc/Dispatch. This cannot be due to these changes could it? |
Contributor
|
@swift-ci please smoke test |
mattmassicotte
changed the title
Contributor
Author
|
In the end, deferring back to #84802. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another shot at #84802
The associated proposal is here: swiftlang/swift-evolution#2990
Adopts typed throws into the suite of Task creation APIs. Also, per the proposal, this removes
@discardableResultfrom the variants that have a non-Nevererror.