[cxx-interop] Consider SWIFT_SHARED_REFERENCE and co Escapable - #91393
Open
Xazax-hun wants to merge 1 commit into
Open
[cxx-interop] Consider SWIFT_SHARED_REFERENCE and co Escapable#91393Xazax-hun wants to merge 1 commit into
Xazax-hun wants to merge 1 commit into
Conversation
This PR makes sure FRTs always considered as escapable. So conflicting or redundant attributes are diagnosed. Also, this adds some fixes where some diagnostics were not emitted for forward declarations or type aliases. A templated shared reference with a non-escapable template argument now should trigger an error. rdar://179532898
Xazax-hun
requested review from
egorzhdan,
j-hui and
susmonteiro
as code owners
August 11, 2026 18:38
Xazax-hun
requested review from
beccadax,
hnrklssn,
ian-twilightcoder and
patrykstefanski
as code owners
August 11, 2026 18:38
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure FRTs always considered as escapable. So conflicting or redundant attributes are diagnosed. Also, this adds some fixes where some diagnostics were not emitted for forward declarations or type aliases. A templated shared reference with a non-escapable template argument now should trigger an error.
rdar://179532898