[Embedded] Mark ManagedBuffer.capacity as unavailable - #91407
Open
Azoy wants to merge 4 commits into
Open
Conversation
Azoy
marked this pull request as ready for review
August 11, 2026 22:06
Contributor
Author
|
@swift-ci please smoke test |
glessard
approved these changes
Aug 11, 2026
Contributor
Author
|
@swift-ci please smoke test |
lorentey
requested changes
Aug 12, 2026
lorentey
left a comment
lorentey
left a comment
Member
There was a problem hiding this comment.
The capacity is typically also stored in the header; allocating a full extra word on storing it for a marginal benefit is quite wasteful, especially on embedded platforms.
On platforms where malloc_size isn't available (like OpenBSD), we simply make var capacity unavailable. There is no reason we should not do the exact same thing here.
Azoy
changed the title
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
malloc_sizereference from embedded (which might not exist on some platforms) by making this API unavailable entirely. Clients should store their own reference to the allocated capacity instead.Resolves: rdar://184234583