feat: memory file system #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A few things for review: |
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
Would you mind keeping the existing indent style as much as possible? It would make it easier to review:)
Contributor
Author
|
I think you can disable whitespace changes from the PR review settings; do you have a prettier config for the project I can apply?
Sent via Superhuman iOS ( ***@***.*** )
…On Thu, Feb 27, 2025 at 7:50 AM, Yuta Saito < ***@***.*** > wrote:
***@***.**** commented on this pull request.
Would you mind keeping the existing indent style as much as possible? It
would make it easier to review:)
—
Reply to this email directly, view it on GitHub (
#5 (review) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAJ4VNOIGOPEVTKBL3VZOBD2RZAM5AVCNFSM6AAAAABX5VKMZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBWGEZTIOBRHE
).
You are receiving this because you authored the thread. Message ID: <swiftwasm/uwasi/pull/5/review/2646134819
@ github. com>
|
kateinoigakukun
approved these changes
Feb 27, 2025
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
Seems good to me. Thank you for upstreaming!
Member
|
I'll make some follow-up for testing later but let's merge this now |
This was referenced Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams the memory file system I was experimenting with.