fix: pass branch positional to gh pr view when --repo is set

[swinney]

Summary

• Pass the working branch as a positional argument to gh pr view in ensure_pr(), fixing the review-gate's inability to find or create PRs when --repo is set
• Add test case 21 verifying the branch positional appears alongside --repo

Fixes fasrc/archi#83.

Root cause

gh pr view --repo owner/name --json number cannot infer the current PR from the local checkout when --repo is passed — it requires an explicit branch, number, or URL as a positional. The runner was calling gh pr view "${repo_args[@]}" --json number without one, so every call errored when RALPH_REPO or GH_REPO was set. The error was caught by ensure_pr's error handling, but classified as "gh errored" and narrated rather than falling through to create — so the gate skipped every turn.

What changed

base/scripts/ralph.sh (ensure_pr): both gh pr view calls (initial check at the top and post-create confirmation) now pass $branch as the positional. Also switched gh pr create --head and --title from $(working_branch) to the already-captured $branch to avoid redundant subshell forks.

base/tests/test_review_gate.sh: new case 21 — with RALPH_REPO=acme/widgets, asserts that gh pr view ... --json number calls include feat (the fixture's working branch) alongside --repo.

Release

Base image only — base/scripts/ changed, so a make build-base rebuild is needed on each loop machine. No skill/template change, so no plugin version bump.

Test plan

• make test — all suites pass (33 review-gate tests including new case 21)
• Case 21 fails on the parent commit, passes after the fix
• Live smoke: a make loop with RALPH_REPO set should create/find the PR

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7075a1412

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Disambiguate numeric branch names from PR numbers

When the working branch is numeric (for example, 123, which is a valid Git branch name), this positional is parsed as PR number 123 rather than as the branch: the installed gh 2.96.0 help defines the selector as <number> | <url> | <branch> (official manual), and its API debug output uses PullRequestByNumber for gh pr view 123. The gate can consequently request review and run checks against unrelated PR #123—and merge it when auto-merge is enabled—instead of creating or locating the branch's PR. Use an unambiguous branch-specific lookup such as gh pr list --head "$branch" rather than passing the raw branch as this overloaded positional.

Useful? React with 👍 / 👎.