CLI for RAG supporting web rag#105
Merged
Merged
Conversation
Closed
fabnemEPFL
requested changes
Jun 27, 2025
Collaborator
fabnemEPFL
left a comment
fabnemEPFL
left a comment
There was a problem hiding this comment.
Overall pretty good, some changes to make before merging.
Regarding the retriever, it changed quite a lot in the master branch compared to how it was when you made this branch. It would be nice if you could take the current version from the master branch and transpose the additions for web search on it. Let me know if you lack time, I can do it if needed.
Matthew2357
changed the title
fabnemEPFL
reviewed
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command-interface for RAG and WebRAG, with the latter using langchain/duckduckgo web search.