versioned; less chatty ocf#24
Conversation
There was a problem hiding this comment.
Pull request overview
Updates container environment configuration to use a shared, infrastructure-managed OCF mount path (instead of a user-specific bin path), aligning both current and legacy serving configs.
Changes:
- Replaced
/iopsstor/.../a09/xyao/bin:/ocfbinwith/capstor/.../infra01/ocf-share:/ocfbinacross vLLM and sglang env TOMLs. - Applied the same mount change consistently in both
src/swiss_ai_model_launchandlegacy/servingenvironments.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/swiss_ai_model_launch/assets/envs/vllm.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| src/swiss_ai_model_launch/assets/envs/sglang.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| src/swiss_ai_model_launch/assets/envs/sglang_kimi.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| legacy/serving/envs/vllm.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| legacy/serving/envs/sglang.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| legacy/serving/envs/sglang_kimi.toml | Switches /ocfbin mount to infra-managed ocf-share path |
| legacy/serving/envs/sglang_glm.toml | Switches /ocfbin mount to infra-managed ocf-share path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AryanAhadinia
left a comment
There was a problem hiding this comment.
I tested your new PR. It is great! But just a small issue. In the middle of process, I think we are doing a busy-waiting and check for peers in a table in a loop. without sleep. As a result, every microsecond, a line of log is dropped for that. Look at the below logs timestamps.
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.178+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.179+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in table
2026-03-20T18:02:26.180+0100 ERROR provider provider/reprovider.go:510 reproviding failed failed to find any peer in tableThe rest is great! Thanks!
|
Good find, the busy loop isn't in our code but inside the boxo provider/reprovider library (a dependency of ipfs-lite). I think for now it is ok to leave since it's in this state for a very short time and changing it might require a lot more testing. In the interim i've suppressed that libraries logs to just FATAL ones. Steps:
These are complete. Can you retest? I launched this on DEV with: |
No description provided.