Fix UnicodeDecodeError When Reading Job Log Files#45
Merged
Conversation
Member
Author
|
The |
62bfd3b to
7f2385f
Compare
Member
Author
Now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reading
log.out/log.errfrom Slurm and FirecREST jobs could raise aUnicodeDecodeErrorin two scenarios:Example error:
Fix
Adds a
decode_log(data: bytes) -> strutility that:errors="replace"for any other malformed bytes elsewhere in the contentBoth
SlurmLauncherandFirecRESTLaunchernow read log files as bytes and pass them throughdecode_log.